[PATCH 1/3] xlat/v4l2*.in: update of various v4l2's flags

[Dmitry V. Levin]

On Tue, Apr 04, 2017 at 11:49:44PM +0300, Edgar Kaziahmedov wrote:
> On Tue, 4 Apr 2017 03:27:35 +0300
> "Dmitry V. Levin" <ldv at altlinux.org> wrote:
> 
> > On Wed, Mar 29, 2017 at 11:55:42PM +0300, Edgar Kaziahmedov wrote:
> > > Linux  4.4: V4L2_BUF_TYPE_SDR_OUTPUT, V4L2_COLORSPACE_DCI_P3,
> > > V4L2_COLORSPACE_BT2020
> > > Linux  4.2: V4L2_BUF_FLAG_LAST, V4L2_COLORSPACE_RAW
> > > Linux  3.8: V4L2_MEMORY_DMABUF
> > > Linux  3.6: V4L2_BUF_FLAG_INPUT is not useful
> > > Linux 3.19: V4L2_COLORSPACE_ADOBERGB
> > > Linux 3.17: V4L2_CAP_EXT_PIX_FORMAT
> > > Linux 3.15: V4L2_BUF_TYPE_SDR_CAPTURE, *TSTAMP* and *TIMESTAMP*
> > > V4L2_CAP_SDR_CAPTURE, V4L2_CAP_SDR_OUTPUT  
> > 
> > Thanks.  When I said it won't harm if you added the kernel version
> > you are synchronising xlat/v4l2*.in files with, I meant just a kernel
> > version, e.g. v4.10 or v4.11-rc5.  The investigation you made is not
> > necessary for this particular change, but it may help in the future.
> > 
> > > * xlat/v4l2_buf_flags.in: add new flags  
> > 
> > style: it should start with a capital letter and end with a dot,
> > see "git log" for various examples.
> > 
> > V4L2_BUF_FLAG_INPUT was removed in Linux 3.6, so you sync removes it
> > but the changelog just says about new flags.
> > 
> > This piece of changelog should look this way:
> > 
> > * xlat/v4l2_buf_flags.in: Remove V4L2_BUF_FLAG_INPUT that was removed
> > by linux kernel commit v3.6-rc1~28^2~240.
> > Add V4L2_BUF_FLAG_PREPARED, V4L2_BUF_FLAG_NO_CACHE_INVALIDATE, and
> > V4L2_BUF_FLAG_NO_CACHE_CLEAN introduced by linux kernel commit
> > v3.2-rc1~63^2~55.
> > Add V4L2_BUF_FLAG_TIMESTAMP_MASK, V4L2_BUF_FLAG_TIMESTAMP_UNKNOWN,
> > and V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC introduced by linux kernel
> > commit v3.9-rc1~93^2~536.
> > Add V4L2_BUF_FLAG_TIMESTAMP_COPY introduced by linux kernel commit
> > v3.10-rc1~136^2~560.
> > Add V4L2_BUF_FLAG_TSTAMP_SRC_MASK, V4L2_BUF_FLAG_TSTAMP_SRC_EOF,
> > and V4L2_BUF_FLAG_TSTAMP_SRC_SOE introduced by linux kernel commit
> > v3.15-rc1~85^2~186.
> > Add V4L2_BUF_FLAG_LAST introduced by linux kernel commit
> > v4.2-rc1~107^2~389.
> > 
> > Or you could just have written "Add new V4L2_BUF_FLAG_* constants."
> > instead of this detailed changelog.
> 
> Oh, I got it, an actully, I thought that it could look a little bit
> overloaded. The reason of a wrong patch format is that I got used
> to git-style, no more.

Well, this is a git style, with a gnu style changelog entry appended. :)


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170405/5cd45977/attachment.bin>