[PATCH v7] Implement -e trace=%statfs option to trace and group statfs, statfs64, statvfs syscalls

[Abhishek Tiwari]

On Sat, Apr 1, 2017 at 10:35 AM, Abhishek Tiwari
<erabhishektiwarics at gmail.com> wrote:
> On Sat, Apr 1, 2017 at 1:51 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
>> On Sat, Apr 01, 2017 at 01:02:33AM +0530, Abhishek Tiwari wrote:
>>> while grouping I found that osf_statfs has following entries
>>>
>>>   linux/alpha/syscallent.h:188:[160] = { 3,   TF|TSF,
>>> SEN(osf_statfs),        "osf_statfs"        },
>>>   linux/alpha/syscallent.h:233:[227] = { 3,   TF|TSF,
>>> SEN(osf_statfs),        "osf_statfs64"      },
>>>
>>> Should the second entry be
>>>  linux/alpha/syscallent.h:233:[227] = { 3,   TF|TSF,
>>> SEN(osf_statfs64),        "osf_statfs64"      },
>>>
>>> and not
>>> linux/alpha/syscallent.h:233:[227] = { 3,   TF|TSF,
>>> SEN(osf_statfs),        "osf_statfs64"      },
>>
>> No, I don't think so.  There is a single parser for both syscalls:
>>
>> $ grep osf_statfs alpha.c
>> SYS_FUNC(osf_statfs)
>>
>> This is a dumb parser, it doesn't decode neither struct osf_statfs
>> nor struct osf_statfs64.
>>
>>> and then grouped under statfs64 ?
>>>
>>> If entry is correct what group should I put for this file statfs or statfs64 ?
>>
>> Why do you want to separate statfs and statfs64?
>
> For commit message, you suggested to rewrite ordering of file according to
> syscall it contains i.e. statfs, statfs64 and statvfs
>
> From previous reply
>
>>>"In some of these files, there is just statfs, in some others it's just
>>>statfs64, in a few more you change both statfs and statfs64, and statvfs
>>>is a very rare beast found only in one file.
>>>
>>>Let's reorder the list of changed syscallent files into these groups so
>>>the changes being made would have more correct descriptions."

Please review attached patch


>>
>> --
>> ldv
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Strace-devel mailing list
>> Strace-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/strace-devel



-- 
Abhishek Tiwari
M.Tech (CS),
IIT Kharagpur.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v8-0001-Implement-e-trace-statfs-option-to-trace-statfs-s.patch
Type: text/x-patch
Size: 36737 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170402/0ad99a06/attachment.bin>