[PATCH 3/8] keyctl: Do not print comma for KEYCTL_SESSION_TO_PARENT command

Eugene Syromyatnikov evgsyr at gmail.com
Thu Sep 29 12:56:20 UTC 2016


Since this command doesn't have any additional arguments, the comma does
not needed. Since this is the only command which lacks additional
arguments, it's better to add special case for it rather than add
printing of comma to all other commands.

* keyctl.c (SYS_FUNC(keyctl)): Add check for command not being
  KEYCTL_SESSION_TO_PARENT when printing comma dividing cmd argument
  from the rest.
---
 keyctl.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/keyctl.c b/keyctl.c
index a0bbbd0..c9081b7 100644
--- a/keyctl.c
+++ b/keyctl.c
@@ -214,7 +214,13 @@ SYS_FUNC(keyctl)
 
 	if (entering(tcp)) {
 		printxval(keyctl_commands, cmd, "KEYCTL_???");
-		tprints(", ");
+
+		/*
+		 * For now, KEYCTL_SESSION_TO_PARENT is the only cmd without
+		 * arguments.
+		 */
+		if (cmd != KEYCTL_SESSION_TO_PARENT)
+			tprints(", ");
 	}
 
 	switch (cmd) {
-- 
1.7.10.4





More information about the Strace-devel mailing list