[PATCH 06/11] fadvise: Change printing of len argument to unsigned in fadvise64 syscall

Dmitry V. Levin ldv at altlinux.org
Tue Sep 27 08:46:37 UTC 2016


On Thu, Sep 22, 2016 at 12:21:20AM +0300, Eugene Syromyatnikov wrote:
> long sys_fadvise64(int fd, loff_t offset, size_t len, int advice);

At the same time, the implementation does
SYSCALL_DEFINE4(fadvise64, int, fd, loff_t, offset, size_t, len, int, advice)
{
	return sys_fadvise64_64(fd, offset, len, advice);
}

This is an implicit cast from size_t to loff_t, so for all intents and
purposes (see e.g. the check for len < 0 inside sys_fadvise64_64) it's
the same loff_t type.  I don't think it worths the change.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160927/f5e85dd2/attachment.bin>


More information about the Strace-devel mailing list