[PATCH] device mapper ioctl

Masatake YAMATO yamato at redhat.com
Fri Nov 11 03:13:35 UTC 2016


>>
>> Here I'm sending the device mapper ioctl patch with these changes merged.
> 
> Hello.
> 
> Thank you for your contribution. The implementation of DM_* ioctl
> decoding is now in strace's master, you can check it out at
> https://github.com/strace/strace/commit/a507a0bb777c552e43e1e45f302703a09ffea1b8
> Could you please review it and let us know if there are any issues?


It works fine on my Fedora 24(x86_64).
"make check" says "PASS" about ioctl_dm.test and  ioctl_dm-v.test.

Very useful. Thank you.

Masatake YAMATO

> 
>> In this piece of code:
>> +       dm_arg_open3->target3.next = 0xdeadbeef;
>> +       dm_arg_open3->param3[0] = '\1';
>> +       dm_arg_open3->param3[1] = '\2';
>> +       dm_arg_open3->param1[2] = '\0';
>> there should be "dm_arg_open3->param3[2]" instead of
>> "dm_arg_open3->param1[2]". "dm_arg_open3->param1[2]" produces a warning
>> about access beyond the end of array.
> Thank you for noticing, it was an oversight on my part.
> 
>> Mikulas
> 
> 
> -- 
> Eugene "eSyr" Syromyatnikov
> mailto:evgSyr at gmail.com
> xmpp:eSyr at jabber.{ru|org}




More information about the Strace-devel mailing list