[PATCH] Add btrfs ioctl support.

[Dmitry V. Levin]

On Fri, May 13, 2016 at 11:32:55AM -0400, Jeff Mahoney wrote:
> On 5/13/16 11:30 AM, Line Printer wrote:
> > On Fri, May 13, 2016 at 6:01 PM, Jeff Mahoney <jeffm at suse.com> wrote:
> >> On 5/13/16 10:57 AM, Line Printer wrote:
> >>> On Thu, May 5, 2016 at 3:07 AM,  <jeffm at suse.com> wrote:
> >>>> From: Jeff Mahoney <jeffm at suse.com>
> >>>>
> >>>>  btrfs.c                            | 1298 ++++++++++++++++++++++++++++++++++++
> >>>
> >>> Would you care to enrich your code with a number of tests? You seem to
> >>> be most suitable for this task.
> >>
> >> I had started work on this, but the main issue is that you need an
> >> actual file system to test and modify. It quickly turns into a btrfs
> >> regression test suite instead of strace tests and introduces a
> >> requirement on the btrfs userspace tools.
> > 
> > Take a look at tests/ioctl_v4l2.c. By passing -1 as the first argument
> > to ioctl(2) you should be able to test at least some requests.
> 
> Testing EBADF seems like pretty pointless testing.

This way you can fully test all _IOW ioctls and partially test
_IOWR ioctls, which is definitely better than nothing.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160513/c92d0b84/attachment.bin>