[PATCH 1/2] Decode UFFDIO_* ioctls

Dmitry V. Levin ldv at altlinux.org
Tue May 10 11:22:04 UTC 2016


On Tue, May 10, 2016 at 10:54:00AM +0100, Dr. David Alan Gilbert wrote:
> * Dmitry V. Levin (ldv at altlinux.org) wrote:
[...]
> > BTW, whoever marked these two ioctls with _IOR clearly missed the point:
> > an ioctl that passes data from userspace to the kernel is a write ioctl
> > and should be marked with _IOW.  Now it's too late to change the ABI and
> > we'll have to live with two write-only _IOR ioctls.
> 
> Thanks; I mentioned this to Andrea; he'll post a patch to comment it in the
> userfaultfd.h header and also add a comment to the kernel's ioctl header
> making clear which way IOR/IOW means.

Great.  So this source of errors will hopefully come to an end after all.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160510/79150455/attachment.bin>


More information about the Strace-devel mailing list