[PATCH] tests: add openat.test

[Katerina Koukiou]

On Fri, Mar 25, 2016 at 9:40 PM, Katerina Koukiou
<k.koukiou at googlemail.com> wrote:
> * tests/openat.c: New file.
> * tests/openat.test: New test.
> * tests/.gitignore: Add openat.
> * tests/Makefile.am (check_PROGRAMS): Likewise.
> (TESTS): Add openat.test.
> ---
>  tests/.gitignore  |  1 +
>  tests/Makefile.am |  2 ++
>  tests/openat.c    | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/openat.test | 11 ++++++++
>  4 files changed, 89 insertions(+)
>  create mode 100644 tests/openat.c
>  create mode 100755 tests/openat.test
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index d1fb6d4..905595c 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -79,6 +79,7 @@ netlink_inet_diag
>  netlink_unix_diag
>  newfstatat
>  oldselect
> +openat
>  pc
>  personality
>  pipe
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index a08025c..6bd5092 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -128,6 +128,7 @@ check_PROGRAMS = \
>         netlink_unix_diag \
>         newfstatat \
>         oldselect \
> +       openat \
>         pc \
>         personality \
>         pipe \
> @@ -293,6 +294,7 @@ DECODER_TESTS = \
>         net.test \
>         newfstatat.test \
>         oldselect.test \
> +       openat.test \
>         personality.test \
>         pipe.test \
>         poll.test \
> diff --git a/tests/openat.c b/tests/openat.c
> new file mode 100644
> index 0000000..63d0393
> --- /dev/null
> +++ b/tests/openat.c
> @@ -0,0 +1,75 @@
> +/*
> + * Copyright (c) 2016 Katerina Koukiou <k.koukiou at gmail.com>
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. The name of the author may not be used to endorse or promote products
> + *    derived from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include "tests.h"
> +#include <sys/syscall.h>
> +
> +#if defined __NR_openat
> +
> +# include <fcntl.h>
> +# include <stdio.h>
> +# include <unistd.h>
> +# include <errno.h>
> +
> +int
> +main(void)
> +{
> +       static const char fname[] = "openat_test_file";
> +       int fd;
> +
> +       fd = syscall(__NR_openat, -100, fname, O_RDONLY|O_CREAT, 0400);
> +       if (fd == -1) {
> +               if (errno == ENOSYS) {
> +                       printf("openat(AT_FDCWD, \"%s\", O_RDONLY|O_CREAT"
> +                              ", 0400) = -1 ENOSYS (%m)\n", fname);
> +               } else {
> +                       perror_msg_and_fail("openat");
> +               }
> +       } else {
> +               printf("openat(AT_FDCWD, \"%s\", O_RDONLY|O_CREAT"
> +                      ", 0400) = %d\n", fname, fd);
> +               close(fd);
> +               if (unlink(fname) == -1)
> +                       perror_msg_and_fail("unlink");
> +               fd = syscall(__NR_openat, -100, fname, O_RDONLY);
> +               if (fd == -1 && errno == ENOENT) {
> +                       printf("openat(AT_FDCWD, \"%s\", O_RDONLY) = %d ENOENT"
> +                              " (%m)\n", fname, fd);
> +               } else {
> +                       perror_msg_and_fail("openat");
> +               }
> +       }
> +
> +       puts("+++ exited with 0 +++");
> +       return 0;
> +}
> +
> +#else
> +
> +SKIP_MAIN_UNDEFINED("__NR_openat")
> +
> +#endif
> diff --git a/tests/openat.test b/tests/openat.test
> new file mode 100755
> index 0000000..7f52d82
> --- /dev/null
> +++ b/tests/openat.test
> @@ -0,0 +1,11 @@
> +#!/bin/sh
> +
> +# Check openat syscall decoding.
> +
> +. "${srcdir=.}/init.sh"
> +
> +run_prog > /dev/null
> +OUT="$LOG.out"
> +run_strace -eopenat $args > "$OUT"
> +match_diff "$LOG" "$OUT"
> +rm -f "$OUT"
> --
> 2.5.0
>

I made the suggested changes.  Though, I am not sure I fully
understand what you meant by saying "When breaking long lines, we
usually indent not with one tabstop but under the object being
wrapped". I hope the new patch applies to this.
Thank you for your guidance.
Katerina