[PATCH] Added -e trace=scheduler option for tracing scheduler related syscalls.

Dmitry V. Levin ldv at altlinux.org
Wed Mar 16 17:44:27 UTC 2016


On Tue, Mar 15, 2016 at 12:01:47PM +0530, student wrote:
> From: Md Haris Iqbal <haris.phnx at gmail.com>
> 
> ---
>  NEWS                          |  1 +
>  defs.h                        |  1 +
>  linux/32/syscallent.h         | 24 ++++++++++++------------
>  linux/64/syscallent.h         | 24 ++++++++++++------------
>  linux/alpha/syscallent.h      | 24 ++++++++++++------------
>  linux/arm/syscallent.h        | 24 ++++++++++++------------
>  linux/avr32/syscallent.h      | 24 ++++++++++++------------
>  linux/bfin/syscallent.h       | 24 ++++++++++++------------
>  linux/hppa/syscallent.h       | 24 ++++++++++++------------
>  linux/i386/syscallent.h       | 24 ++++++++++++------------
>  linux/ia64/syscallent.h       | 24 ++++++++++++------------
>  linux/m68k/syscallent.h       | 24 ++++++++++++------------
>  linux/microblaze/syscallent.h | 24 ++++++++++++------------
>  linux/mips/syscallent-n32.h   | 24 ++++++++++++------------
>  linux/mips/syscallent-n64.h   | 24 ++++++++++++------------
>  linux/mips/syscallent-o32.h   | 24 ++++++++++++------------
>  linux/powerpc/syscallent.h    | 24 ++++++++++++------------
>  linux/powerpc64/syscallent.h  | 24 ++++++++++++------------
>  linux/s390/syscallent.h       | 24 ++++++++++++------------
>  linux/s390x/syscallent.h      | 24 ++++++++++++------------
>  linux/sh/syscallent.h         | 20 ++++++++++----------
>  linux/sh64/syscallent.h       | 20 ++++++++++----------
>  linux/sparc/syscallent.h      | 28 ++++++++++++++--------------
>  linux/sparc64/syscallent.h    | 28 ++++++++++++++--------------
>  linux/x32/syscallent.h        | 24 ++++++++++++------------
>  linux/x86_64/syscallent.h     | 24 ++++++++++++------------
>  linux/xtensa/syscallent.h     | 24 ++++++++++++------------
>  strace.1                      |  3 +++
>  syscall.c                     |  4 ++++
>  29 files changed, 309 insertions(+), 300 deletions(-)
> 
> diff --git a/NEWS b/NEWS
> index 7779f65..2f59faa 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -12,6 +12,7 @@ Noteworthy changes in release ?.?? (????-??-??)
>      spent in decoding socket details in -yy mode.
>    * Implemented decoding of copy_file_range syscall.
>    * Implemented dumping of vmsplice syscall.
> +  * Added -e trace=scheduler option for tracing scheduler related syscalls.
>  
>  * Bug fixes
>    * Fixed build on arc, metag, nios2, or1k, and tile architectures.

Thanks, that's the kind of patch I expected.  It misses a little piece,
though, that could be easily spotted with "make check".

Ideally, every new feature should be accompanied by a test,
so you might want to write a test as well.

A few trivial comments about the commit message:
- the first line of the commit message should skip the period;
- describe your changes in imperative mood, e.g. "Add xyz option"
instead of "Added xyz option", as if you are giving orders
to the codebase to change its behavior.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160316/1ec17267/attachment.bin>


More information about the Strace-devel mailing list