[PATCH] tests: chdir.test

[Dmitry V. Levin]

Hi,

On Fri, Mar 11, 2016 at 11:22:23PM +0530, Jay Joshi wrote:
> Hello,
> 
> This is my first attempt to add test for syscall (here, chdir). Any
> suggestion, comment, criticism is welcomed.

chdir is already well covered, see
$ git grep chdir tests

You must have missed my recommendation to check current coverage report
at https://codecov.io/github/strace/strace before adding new tests.

I think you'd rather take something that's not tested at all.

> +#if defined __NR_chdir

Why do you think that libc wrapper for chdir syscall is not suitable?

> +  if (errno == ENOSYS) {
> +    printf("chdir(\"%s\") = -1 ENOSYS (%m)\n", sample_dir);

chdir failing with ENOSYS?  Really?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160312/ae5eefd9/attachment.bin>