Add test for fchmod and fchmodat

[Dmitry V. Levin]

Hi,

On Wed, Mar 09, 2016 at 11:10:41PM +0000, Fabien Siron wrote:
> Hello list,
> 
> Before trying to apply for GSOC, I think it's a really good idea to make
> a first contribution. Thus, it seems that an easy and useful contribution
> would be a test.

Definitely.  As virtually every GSoC project expects writing some tests,
the experience of extending test suite would be useful anyway.

> I noticed that a chmod test has been recently added to
> the project and I think that complete the *chmod family* test could be
> good. But I have two questions:
> 
> * Does this choice of test is a good one?

Neither fchmod nor fchmodat is covered by the test suite yet:
$ git grep fchmod tests/ | wc -l
0
I think you've made a good choice, fchmodat is more interesting than plain
chmod and still reasonably easy to start with.

> * If yes, do fchmod and fchmodat have to be tested in the same test as
> chmod or in a separated one?

Some modern architectures don't implement chmod syscall, and relatively
old kernels don't implement fchmodat.  Even for this simple reason all
these syscalls have to be tested separately.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160310/7e48cb8f/attachment.bin>