[PATCH 1/3] tests: add xetpriority.test

Dmitry V. Levin ldv at altlinux.org
Mon Mar 7 22:36:27 UTC 2016


On Mon, Mar 07, 2016 at 11:29:49AM +0800, Fei, Jie/费 杰 wrote:
> On 03/04/2016 10:46 PM, Dmitry V. Levin wrote:
> >On Fri, Mar 04, 2016 at 05:10:46PM +0800, Fei Jie wrote:
> >[...]
> >>* linux/dummy.h: (sys_getpriority, sys_setpriority): Change to 
> >>printargs_d.
> >Why?
> >
> I added this to make strace print xetpriority in the following format:
> getpriority(0, 17207) = 20
> instead of
> getpriority(PRIO_PROCESS, 18446744069414605786) = 20.

Why do you think that
	getpriority(0, 17207) = 20
is better than
	getpriority(PRIO_PROCESS, 17207) = 20
?

I'd agree if you suggested to print 2nd argument of getpriority and
setpriority using %d format, but what's wrong with current symbolic
representation of their 1st argument?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160308/9ce2e5cb/attachment.bin>


More information about the Strace-devel mailing list