[PATCH v6 1/4] Add a enum for decoding to tprint_iov() and tprint_iov_upto().

[Dmitry V. Levin]

On Tue, Jun 21, 2016 at 02:42:43PM +0000, Fabien Siron wrote:
> This commit introduces a new type iov_decode which will be used instead
> of the integer "decode" as a parameter.

The first line of commit message shouldn't end with dot.

No need to begin each commit message with "This commit introduces",
a simple "Introduce" is enough.

[...]
> +	switch (c->decode_iov) {
> +		case IOV_DECODE_STR:
> +		{
> +			if (len > c->data_size)
> +				len = c->data_size;
> +			c->data_size -= len;
> +			printstr(tcp, iov[0], len);
> +			break;
> +		}

These braces are redundant.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160621/3c3f5141/attachment.bin>