[PATCH v3 2/7] Add a general netlink socket parser

Fabien Siron fabien.siron at epita.fr
Thu Jun 16 14:33:24 UTC 2016


Quoting Dmitry V. Levin (2016-06-16 13:38:06)
> On Thu, Jun 16, 2016 at 01:26:15PM +0000, Fabien Siron wrote:
> > Quoting Dmitry V. Levin (2016-06-16 10:08:22)
> > > Alternatively, rather than making decode_netlink_iov work like
> > > tprint_iov_upto, you can extend tprint_iov_upto to print netlink related
> > > data.  For example, "decode_iov" argument of tprint_iov_upto can be turned
> > > from de-facto boolean printaddr/printstr value into enum.
> > 
> > I think that this is a good idea but as all the functions that call
> > tprint_iov_upto() or tprint_iov() must be patched, it's maybe better to do
> > that as a seperated commit (maybe a future improvement).
> 
> Yes, a separate commit is a good idea.
> 

The problem is that we may want to add some arguments in the future
to decode_netlink_msg() for further parsing (either the protocol or the
file descriptor at least) and tprint_iov_upto()
doesn't seem to be able to transmit some arguments.

Regards,
--
Fabien Siron




More information about the Strace-devel mailing list