[PATCH 1/4] util.c: Add helper for string to int conversions

Dmitry V. Levin ldv at altlinux.org
Fri Jul 29 00:24:31 UTC 2016


On Wed, Jul 27, 2016 at 08:41:14PM +0200, Nahim El Atmani wrote:
> From: Nahim El Atmani <naam at lse.epita.fr>
> From: Nahim El Atmani <nahim+dev at naam.me>

Could you choose just one "From"?

> * util.c (string_to_int): New function.

This would be OK if subsequent patches would use it.
Apparently, they don't: in the only place where string_to_int is called
the string starts with a digit so string_to_uint is enough.

> * defs.h: Add it.

This would have to be
* defs.h (string_to_int): New prototype.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160729/c7924adb/attachment.bin>

More information about the Strace-devel mailing list