[PATCHv1] strace: add :signal option to efault

seraph kirkseraph at gmail.com
Tue Dec 27 11:24:41 UTC 2016


Thanks for the feedback. I've just sent the requested modifications.

On Tue, Dec 27, 2016 at 01:59:15AM +0300, Dmitry V. Levin wrote:
> >  	if (cflag == CFLAG_ONLY_STATS) {
> >  		res = 0;
> > @@ -716,7 +718,7 @@ trace_syscall_entering(struct tcb *tcp)
> >  	/* Measure the entrance time as late as possible to avoid errors. */
> >  	if (Tflag || cflag)
> >  		gettimeofday(&tcp->etime, NULL);
> > -	return res;
> > +	return 0;
> 
> Why do you need to ignore return code?
> This looks wrong and will surely break things.

Sorry about that, it is a remnant of my old implementation... It is gone 
now, hopefully.

> Do you think you could also write a test for this new feature?

Sure, will try to do it soon.




More information about the Strace-devel mailing list