readv.test is fail on Ubuntu 16.04 x86_64

[Dmitry V. Levin]

Hi,

On Sun, Dec 04, 2016 at 07:59:48PM +0800, JingPiao Chen wrote:
> Environment: Ubuntu 16.04 x86_64
> Version: dcc9b9cdb2cd6de7c5b300b8d1f5dfb3f0b31ab2
> 
> readv.test is fail on Ubuntu 16.04 x86_64
> 
> test-suite.log/readv.log:
> 
> 251 FAIL: readv
> 252 ===========
> 253 
> 254 ../strace: invalid descriptor '65534'
> 255 readv.test: failed test: ../strace -a16 -eread=65534 -ewrite=65535 -e trace=readv,writev ./readv failed with code 1
> 256 FAIL readv.test (exit status: 1)

Thanks for reporting.  This was a limitation in strace, fixed by commit
v4.14-195-g05ac490cc79e2369a60da23e696b67fcd6012762 that replaced old
-eread=/-ewrite= implementation with a new bit set based one.

> My patch:
> 
> From c58e2972c732eb545c7c3bff76222f1806474a03 Mon Sep 17 00:00:00 2001
> From: JingPiao Chen <chenjingpiao at foxmail.com>
> Date: Sun, 4 Dec 2016 19:56:19 +0800
> Subject: [PATCH] tests: fix maximum fd in pipe_maxfd

I think that if a test hits a bug, the first idea should be to fix the bug,
not to workaround the bug in the test.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20161207/315357a8/attachment.bin>