[PATCH 3/8] futex: Some refinement to unknown command argument formatting

Eugene Syromyatnikov evgsyr at gmail.com
Mon Aug 29 15:12:15 UTC 2016


Several changes have been performed:
 * alternate form is used for timeout value since it is pointer half
   of the time. And half of the time it is not, which can be confusing
   without number base prefix.
 * uaddr is pointer across all existing operations, so it's rather expected
   that it would be the same in possible future operations.
 * val3 numeric base is also different in different commands, so it's
   better to use alternate form for it too.

* futex.c (SYS_FUNC(futex)): update formatting in unknown command case.
---
 futex.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/futex.c b/futex.c
index 44b90e0..6bd739f 100644
--- a/futex.c
+++ b/futex.c
@@ -107,7 +107,10 @@ SYS_FUNC(futex)
 	case FUTEX_TRYLOCK_PI:
 		break;
 	default:
-		tprintf(", %lx, %lx, %x", timeout, uaddr2, val3);
+		tprintf(", %#lx", timeout);
+		tprints(", ");
+		printaddr(uaddr2);
+		tprintf(", %#x", val3);
 		break;
 	}
 
-- 
1.7.10.4





More information about the Strace-devel mailing list