[PATCH 1/2] Fill old_value argument in timer{,fd}_xettime test

Eugene Syromyatnikov evgsyr at gmail.com
Mon Aug 22 08:48:39 UTC 2016


It is needed in order to differentiate it from the value returned by the
call. As a consequence, it enables revealing possible bugs in syscall
parsers, for example, when the value read on syscall entering and not on
syscall exiting (as it is the case with timerfd_settime parser).

* tests/timer_xettime.c: Fill old.its field with value different from the
  expected one upon call return.
* tests/timerfd_xettime.c: Likewise.
---
 tests/timer_xettime.c   |    4 ++++
 tests/timerfd_xettime.c |    4 ++++
 2 files changed, 8 insertions(+)

diff --git a/tests/timer_xettime.c b/tests/timer_xettime.c
index 6fcd00e..877f717 100644
--- a/tests/timer_xettime.c
+++ b/tests/timer_xettime.c
@@ -59,6 +59,10 @@ main(void)
 		struct itimerspec its;
 		uint32_t pad[4];
 	} old = {
+		.its = {
+			.it_interval = { 0xdeface5, 0xdeface6 },
+			.it_value = { 0xdeface7, 0xdeface8 }
+		},
 		.pad = { 0xdeadbeef, 0xbadc0ded, 0xdeadbeef, 0xbadc0ded }
 	}, new = {
 		.its = {
diff --git a/tests/timerfd_xettime.c b/tests/timerfd_xettime.c
index a084b66..2742ec2 100644
--- a/tests/timerfd_xettime.c
+++ b/tests/timerfd_xettime.c
@@ -51,6 +51,10 @@ main(void)
 		struct itimerspec its;
 		uint32_t pad[4];
 	} old = {
+		.its = {
+			.it_interval = { 0xdeface5, 0xdeface6 },
+			.it_value = { 0xdeface7, 0xdeface8 }
+		},
 		.pad = { 0xdeadbeef, 0xbadc0ded, 0xdeadbeef, 0xbadc0ded }
 	}, new = {
 		.its = {
-- 
1.7.10.4





More information about the Strace-devel mailing list