[PATCH 0/2] Minor bug in timerfd_settime parser

Eugene Syromyatnikov evgsyr at gmail.com
Mon Aug 22 08:47:02 UTC 2016


Hello.

I've stumbled upon a subtle bug in timerfd_settime parser - it retrieves
old_value argument on entering and not on exiting. Turns out it hasn't
been noticed by timerfd_xettime test since it fills old_value argument
buffer with exactly the same values as returned by the call (more precisely,
it doesn't specify any values so it is filled with zeroes, which are obviously
returned by the first timerfd_settime call). Upon investigation, it is
revealed that timer_xettime test follows the same pattern. As a result,
the following patch set consists of two patches - first one updates tests
and second one fixes the aforementioned problem.

Eugene Syromyatnikov (2):
  Fill old_value argument in timer{,fd}_xettime tests
  Fix old_value argument retrieval in timerfd_settime parser

 tests/timer_xettime.c   |    4 ++++
 tests/timerfd_xettime.c |    4 ++++
 time.c                  |   20 +++++++++++---------
 3 files changed, 19 insertions(+), 9 deletions(-)

-- 
1.7.10.4





More information about the Strace-devel mailing list