[PATCH 3/4] Introduce syscall fault injection feature

Nahim El Atmani nahim+dev at naam.me
Sat Aug 20 00:44:55 UTC 2016


Hi,

On Fri, 29 Jul 2016 17:57:33 +0300, Dmitry V. Levin wrote:
> Date: Fri, 29 Jul 2016 17:57:33 +0300
> From: "Dmitry V. Levin" <ldv at altlinux.org>
> To: strace-devel at lists.sourceforge.net
> Subject: Re: [PATCH 3/4] Introduce syscall fault injection feature
> Message-ID: <20160729145733.GB26261 at altlinux.org>
> In-Reply-To: <20160729150650.57137372 at guinness.lab.lse.epita.fr>
> List-Id: strace development list <strace-devel.lists.sourceforge.net>
> 
> On Fri, Jul 29, 2016 at 03:06:50PM +0200, Gabriel Laskar wrote:
> > On Fri, 29 Jul 2016 04:04:02 +0300, Dmitry V. Levin wrote:
> > > On Wed, Jul 27, 2016 at 08:41:16PM +0200, Nahim El Atmani wrote:
> [...]
> > > >   new configure flag have been created (--enable-fault-injection)
> > > > to keep the build clean on other architectures.  
> > > 
> > > Please don't make this option configurable.  It complicates the code
> > > (== causes mistakes) and gives very little in return.
> > 
> > The goal here was to enable the feature only for architecture where
> > this was really tested, mainly in order to validate the model, and
> > after, enable it without an option, when properly tested on all
> > architectures.
> 
> If these arch-specific functions are difficult to implement,
> let's re-use the approach taken by arch_sigreturn.
> 
> However, all arch specific details are well known so I think
> this is not going to be as difficult as arch_sigreturn.

I'm currently passing tests on MIPS as well as x86 32/64bits. This is not
complicated but getting the test environment for each architecture is time
consumming. Stay tuned!

Thanks

-- 
Nahim El Atmani <nahim+dev at naam.me>
http://naam.me/




More information about the Strace-devel mailing list