[PATCH v2 0/3] Testsuite fixes for mips64

Dmitry V. Levin ldv at altlinux.org
Thu Aug 11 21:08:49 UTC 2016


On Thu, Aug 11, 2016 at 04:33:00PM +0000, James Cowgill wrote:
> These patches fix most of the testsuite failures which happen on 64-bit mips
> (n32 and n64). None of the failures were bugs in strace, but rather bugs in
> the testsuite.
> 
> An example of the failures can be seen here:
> https://buildd.debian.org/status/fetch.php?pkg=strace&arch=mips64el&ver=4.12-3&stamp=1468671031

Merged, thanks!

> The only test which still seems to fail on my machine is the "pwritev" test,
> but I believe that's caused by a kernel bug (which I haven't tracked down yet).

Does this patch changes something with the test result?
(also add #include <errno.h> to make it buildable)

--- a/tests/pwritev.c
+++ b/tests/pwritev.c
@@ -113,6 +113,7 @@ main(void)
 		unsigned int n = LEN + 1 - i;
 		fputs("pwritev(0, ", stdout);
 		print_iovec(iov + i, n, LEN - i);
+		errno = 0;
 		rc = pwritev(0, iov + i, n, offset + LEN + i);
 		printf(", %u, %lld) = %ld %s (%m)\n",
 		       n, (long long) offset + LEN + i, rc, errno2name());

-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160812/55d55568/attachment.bin>


More information about the Strace-devel mailing list