[PATCH 3/3] Add btrfs ioctl support.

[Dmitry V. Levin]

On Thu, Mar 31, 2016 at 09:49:38AM -0400, Jeff Mahoney wrote:
> 1/ Define the macros in multiple places

Please don't. :)

> 2/ Teach xlat/gen.sh to produce two .h files.  One contains the xlat
> structures, the other contains the defines.

This is OK.

> 3/ Teach xlat/gen.sh to wrap the structure definition in a "#ifndef
> XLAT_DEFINES_ONLY" and allow test programs to define that.

This is also OK.

> My preference is #3 since it means no code change outside of the
> xlat/gen.sh script.

#2 also could be implemented just by changing xlat/gen.sh script,
but #3 seems to be the simplest variant.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20160401/8e62c07d/attachment.bin>