[PATCH v2] ioctl: fix ioctl command number decoding in case of conflicts
Dmitry V. Levin
ldv at altlinux.org
Mon Nov 30 15:36:19 UTC 2015
On Mon, Nov 30, 2015 at 04:21:53PM +0100, Patrik Jakobsson wrote:
> On Mon, Nov 30, 2015 at 4:13 PM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > On Mon, Nov 30, 2015 at 02:49:11PM +0100, Patrik Jakobsson wrote:
> >> On Thu, Sep 24, 2015 at 2:45 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> >> > On Wed, Sep 23, 2015 at 10:11:55AM +0200, Gabriel Laskar wrote:
> >> >> When a command number was decoded through ioctl_decode_command_number(),
> >> >> there was no check for conflicts with other potential ioctls numbers.
> >> >
> >> > Merged, thanks.
> >> Hi, sorry for noticing this a bit late but this change makes it
> >> impossible to override the ioctl decoding for drm. The correct
> >> decoding can be done by identifying the driver and I need a way to
> >> stop the generic decoding at that point.
> > Do you mean that you want to be able to turn off ioctl_lookup completely?
> Yes that was my idea. ioctl_lookup() doesn't know about the drm driver
> backing the device so it cannot give us the correct ioctl.
I suppose we could extend ioctl_decode_command_number return code
semantics beyond current 0/1 value.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 819 bytes
Desc: not available
More information about the Strace-devel