[PATCH] getdents: fix typos in array output

[Dmitry V. Levin]

On Thu, Nov 19, 2015 at 11:44:30AM +0100, Gabriel Laskar wrote:
> Array should be enclosed by square brakets, and elements should be
> separated by commas.
> 
> * dirent.c: fix typos in array output of getdents()
> * tests/getdents.awk: change test to fix typos
> * tests/getdents.out: output modified to match output
[...]
> @@ -203,7 +203,7 @@ SYS_FUNC(getdents64)
>  				tprints("...");
>  			}
>  
> -			tprints("}");
> +			tprints("]");
>  		}
>  		if (d->d_reclen < d_name_offset) {
>  			tprints("/* d_reclen < offsetof(struct dirent64, d_name) */");

This is not the right place to change "}" with "]".
I've pushed the correct fix.

I've also pushed a follow-up commit that rewrites getdents.test so that
decoding of both getdents and getdents64 syscalls are now being tested
instead of just one of them that is called by host ls(1).

This new getdents.test uncovered lack of mpers support in getdents parser,
so I've added it, too.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20151120/4685bdd2/attachment.bin>