[Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace
patrik.jakobsson at linux.intel.com
Mon May 11 09:05:09 UTC 2015
On Thu, May 07, 2015 at 08:37:40AM -0700, Jesse Barnes wrote:
> On 05/06/2015 07:48 AM, Patrik Jakobsson wrote:
> > This patch set aims to make strace more useful when tracing i915 ioctls.
> > The ioctl type is first checked for being drm and then the driver
> > backing the opened device is identified by looking at sysfs. Other
> > drivers than i915 can easily be added.
> > Only a subset of the i915 ioctls are included. I will extend this patch
> > set if the approach looks ok. The generic drm ioctls are also missing.
> > Give it a spin with:
> > strace -e trace=ioctl -p `pidof X`
> > Patrik Jakobsson (2):
> > strace/drm: Print extended info for drm and i915 ioctls
> > strace/drm: Print args for most common i915 ioctls
> > Makefile.am | 2 +
> > defs.h | 2 +
> > drm.c | 104 +++++++++++++++++
> > drm_i915.c | 278 +++++++++++++++++++++++++++++++++++++++++++++
> > ioctl.c | 5 +
> > xlat/drm_i915_getparams.in | 28 +++++
> > xlat/drm_i915_ioctls.in | 51 +++++++++
> > xlat/drm_i915_setparams.in | 4 +
> > 8 files changed, 474 insertions(+)
> > create mode 100644 drm.c
> > create mode 100644 drm_i915.c
> > create mode 100644 xlat/drm_i915_getparams.in
> > create mode 100644 xlat/drm_i915_ioctls.in
> > create mode 100644 xlat/drm_i915_setparams.in
> Yeah, this looks pretty cool to me. I'm not familiar with strace
> internals, but the split and extensible design looks reasonable; should
> make it easy to add other drivers and such in the future.
> Who on the strace side can pick this up?
Can I bother you with a review?
More information about the Strace-devel