GSOC2015 - Suggestions/Criticism - Some Test Scripts for Basic System Calls

[Dmitry V. Levin]

On Sat, Mar 14, 2015 at 10:25:48PM +0530, Rohan Bavishi wrote:
> Hi everyone,
> 
> As I had mentioned in the thread before, I had planned to write some
> small test-suite code in order to get familiar with the code base. I
> have come up with some small preliminary test-benches covering
> system-calls 'chdir' and 'fcntl'. I'm posting the Github link, so as
> to not clutter this thread with long, boring code.
> 
> Github: https://github.com/rbavishi/GSOC2015-strace
> 
> Any critique/suggestion regarding coding style, errors, code quality
> is much appreciated.
> 
> Also, I did some crude hacks to include these tests in the Makefile
> for testing, and both of them passed on my system.

There is no need to do crude hacks.
I think it worth investing a few minutes in reading tests/Makefile.am
to understand how to add new tests to the test suite.

Also, please do not introduce yet another coding style.

FYI, commit v4.10-18-g8f54664 simplified the shell part of test suite.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150318/3e3dffe5/attachment.bin>