aarch64 strace decoding of 32-bit arm statfs64...

[Dmitry V. Levin]

On Tue, Mar 17, 2015 at 03:20:56PM -0700, enh wrote:
> i think we've regressed with aarch64 strace decoding arm statfs again.
> i don't think AARCH64 should have been included in this patch.

I have no aarch64 nearby to check this, but, according to kernel headers,

$ git grep -Fw ARCH_PACK_COMPAT_STATFS64 arch/
arch/arm64/include/uapi/asm/statfs.h:#define ARCH_PACK_COMPAT_STATFS64 __attribute__((packed,aligned(4)))
arch/ia64/include/uapi/asm/statfs.h:#define ARCH_PACK_COMPAT_STATFS64 __attribute__((packed,aligned(4)))
arch/x86/include/uapi/asm/statfs.h:#define ARCH_PACK_COMPAT_STATFS64 __attribute__((packed,aligned(4)))

> commit d50949d21c2b07daadc26c7302163dc6066d4a75
> Author: Dmitry V. Levin <ldv at altlinux.org>
> Date:   Mon Mar 2 21:34:02 2015 +0000
> 
>     aarch64, x32: fix decoding of compat personality statfs64/fstatfs64
> 
>     * statfs.c (struct compat_statfs64) [AARCH64 || X32]: Apply the same
>     attributes as on X86_64.
> 
> diff --git a/statfs.c b/statfs.c
> index 6101209..6f5e4d3 100644
> --- a/statfs.c
> +++ b/statfs.c
> @@ -121,7 +121,7 @@ struct compat_statfs64 {
>         uint32_t f_flags;
>         uint32_t f_spare[4];
>  }
> -#if defined(X86_64) || defined(IA64)
> +#if defined AARCH64 || defined X86_64 || defined X32 || defined IA64
>    __attribute__ ((packed, aligned(4)))
>  #endif
>  ;


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150318/735ebcdd/attachment.bin>