[PATCH] aarch64 sigreturn.c

enh enh at google.com
Tue Mar 17 21:57:48 UTC 2015


ah, linux/arch_regs.h was ahead of that on the include path, so
linux/aarch64/arch_regs.h was not getting included.

yeah, fixing the Android.mk fixes that. thanks.

On Tue, Mar 17, 2015 at 2:51 PM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Tue, Mar 17, 2015 at 02:37:30PM -0700, enh wrote:
>> i'm not sure whether you intended these to go in a header file,
>
> In linux/aarch64/arch_regs.h, to be specific.
>
>> but
>> sys_sigreturn doesn't compile for me because of missing declarations
>> for globals from syscall.c. (Android builds with more warnings as
>> errors.)
>>
>> diff --git a/sigreturn.c b/sigreturn.c
>> index 365ef1a..0dc2005 100644
>> --- a/sigreturn.c
>> +++ b/sigreturn.c
>> @@ -17,6 +17,9 @@ int
>>  sys_sigreturn(struct tcb *tcp)
>>  {
>>  #if defined AARCH64 || defined ARM
>> + extern uint64_t *const aarch64_sp_ptr;
>> + extern uint32_t *const arm_sp_ptr;
>> +
>
> These are already declared in linux/aarch64/arch_regs.h
>
>
> --
> ldv
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming The Go Parallel Website, sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for all
> things parallel software development, from weekly thought leadership blogs to
> news, videos, case studies, tutorials and more. Take a look and join the
> conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.




More information about the Strace-devel mailing list