Fix for building against musl

Mike Frysinger vapier at gentoo.org
Tue Mar 10 18:31:32 UTC 2015


On 10 Mar 2015 19:37, Dima Krasner wrote:
> --- strace-4.10-orig/evdev.c	2015-03-10 19:16:03.644273038 +0200
> +++ strace-4.10/evdev.c	2015-03-10 19:28:29.020290753 +0200
> @@ -29,6 +29,7 @@
>  #include "defs.h"
>  
>  #ifdef HAVE_LINUX_INPUT_H
> +#include <asm/ioctl.h>
>  #include <linux/input.h>
>  #include "xlat/evdev_abs.h"
>  #include "xlat/evdev_autorepeat.h"

this has nothing to do with musl.  why do you need it ?

> --- strace-4.10-orig/mknod.c	2015-03-10 19:16:03.608273037 +0200
> +++ strace-4.10/mknod.c	2015-03-10 19:30:46.972294032 +0200
>  
>  #include <fcntl.h>
> +#include <sys/stat.h>
>  
> --- strace-4.10-orig/printmode.c	2015-03-10 19:16:03.652273038 +0200
> +++ strace-4.10/printmode.c	2015-03-10 19:32:11.116296032 +0200
>  
>  #include <fcntl.h>
> +#include <sys/stat.h>

these are because these two files use S_xxx macros which are provided officially 
via sys/stat.h, but also historically via fcntl.h.  could replace fcntl.h by 
sys/stat.h, but including both is safe.

could you write proper changelog entries for your commit please ?  just look at 
the history for examples.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150310/0894ceac/attachment.bin>


More information about the Strace-devel mailing list