Preparing for the next release: call for testing

[Mike Frysinger]

On 02 Mar 2015 22:42, Dmitry V. Levin wrote:
> On Mon, Mar 02, 2015 at 12:04:27PM -0500, Mike Frysinger wrote:
> > On 02 Mar 2015 14:31, Dmitry V. Levin wrote:
> > > On Mon, Mar 02, 2015 at 12:42:45AM -0500, Mike Frysinger wrote:
> > > >  - x32 statfs tracing of x86 binaries fails ?
> > > 
> > > I'd like to see the log.  There are two test-suite.log files on x32,
> > > but only tests/test-suite.log is printed.
> > 
> > FAIL: statfs
> > ============
> > 
> > execve("./statfs", ["./statfs"], [/* 44 vars */]) = 0
> > [ Process PID=476 runs in 32 bit mode. ]
> > access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
> > open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
> > open("/lib/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
> > statfs64("/proc/self/status", 84, {???}) = 0
> > +++ exited with 0 +++
> > statfs.test: failed test: ../strace -efile ./statfs failed to trace "statfs(64)?" properly
> > FAIL statfs.test (exit status: 1)
> 
> I suppose this is the fix:
> 
> --- a/statfs.c
> +++ b/statfs.c
> @@ -121,7 +121,7 @@ struct compat_statfs64 {
>  	uint32_t f_flags;
>  	uint32_t f_spare[4];
>  }
> -#if defined(X86_64) || defined(IA64)
> +#if defined AARCH64 || defined X86_64 || defined X32|| defined IA64
>    __attribute__ ((packed, aligned(4)))
>  #endif
>  ;

x32 now passes w/that

obviously you'll fix the spacing after the "X32" symbol ;)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150302/5257cd8d/attachment.bin>