[PATCH v4] Add decoding for evdev ioctls.

Dmitry V. Levin ldv at altlinux.org
Tue Feb 17 20:21:15 UTC 2015


On Tue, Feb 17, 2015 at 08:04:06PM +0100, Etienne Gemsa wrote:
> > > + struct input_mt_request_layout {
> > > +		uint32_t code;
> > > +		int32_t values[tcp->u_rval/sizeof(int32_t) - 1];
> >
> > Is it correct to use tcp->u_rval here?
> 
> I don't see why tcp->u_rval should not be apropriate, in this case, we use the
> return value on exiting.

If EVIOCGMTSLOTS succeeds, then tcp->u_rval equals to 0 and
tcp->u_rval/sizeof(int32_t) - 1 equals to -1.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150217/d8311bab/attachment.bin>


More information about the Strace-devel mailing list