strace 4.10 doesn't build on MIPS arch

[Dmitry V. Levin]

On Fri, Apr 17, 2015 at 11:06:45AM +0200, Arturo Borrero Gonzalez wrote:
> On 15 April 2015 at 15:52, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > On Wed, Apr 15, 2015 at 11:26:08AM +0200, Arturo Borrero Gonzalez wrote:
> >> On 14 April 2015 at 15:13, Dmitry V. Levin <ldv at altlinux.org> wrote:
> >> > On Tue, Apr 14, 2015 at 09:32:39AM +0200, Arturo Borrero Gonzalez wrote:
> >> >> Hi there!
> >> >>
> >> >> I've been taking a look at the debian log for strace on the MIPS
> >> >> architecture [0].
> >> >> There is a test that doesn't pass and therefore the build is taken as
> >> >> invalid (and the debian package isn't created).
> >> >>
> >> >> For me, the ideal fix is to get the test file passing.
> >> >> I know nothing of the strace source code base, could you please give
> >> >> me a few hints/pointers of how to solve the situation?
> >> >
> >> > Could you re-test with the current HEAD, please?
> >> > (./bootstrap && ./configure && make check)
> >>
> >> Still errors. Find attached the result.
> >
> > Thanks.  Could you update to the current HEAD once more and try with this
> > tentative patch applied, please:
> >
> 
> This is what I get:
> 
> [...]
> gcc -DHAVE_CONFIG_H -I. -I..  -I./linux/mips -I../linux/mips -I./linux
> -I../linux -D_FORTIFY_SOURCE=2 -Wall -Wwrite-strings -Wsign-compare -g
> -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security
> -Wall -g -O2 -MT strace-syscall.o -MD -MP -MF .deps/strace-syscall.Tpo
> -c -o strace-syscall.o `test -f 'syscall.c' || echo '../'`syscall.c
> In file included from ../linux/mips/syscallent.h:3:0,
>                  from ../syscall.c:85:
> ../linux/mips/syscallent-o32.h:3:20: error: 'sys_syscall' undeclared
> here (not in a function)
>  [4000] = { MA, 0,  sys_syscall,   "syscall"  }, /* start of Linux o32 */
>                     ^
> ../syscall.c:622:1: warning: return type defaults to 'int' [-Wreturn-type]
>  SYS_FUNC(syscall)
>  ^

It had to be defined by (regenerated) sys_func.h

> ../syscall.c: In function 'SYS_FUNC':

That's nonsense, SYS_FUNC is a macro.  This might happen if you test this
patch on something older than v4.10-62-ga0bd374, while the current HEAD is
v4.10-66-g71fb134.

> ../syscall.c:1798:3: error: too few arguments to function 'decode_mips_subcall'
>    decode_mips_subcall();

That's correct, it has to be decode_mips_subcall(tcp);


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20150417/faadf338/attachment.bin>