[PATCH] Fix stat decoding for LP64 bionic.

Dmitry V. Levin ldv at altlinux.org
Wed Mar 12 20:52:58 UTC 2014

On Wed, Mar 12, 2014 at 01:44:06PM -0700, enh wrote:
> On Wed, Mar 12, 2014 at 1:36 PM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > On Wed, Mar 12, 2014 at 10:41:42AM -0700, enh wrote:
> > [...]
> >> In patch fb642bb6d63f7ffe2228bf48a6008bc8f56f67ff I fixed aarch64 but broke
> >> x86_64.
> >
> > No code added under #ifdef AARCH64 can ever break x86_64.
> true. the full story is that we need HAVE_STAT64 for a multi-arch
> strace so it can decode stat syscalls correctly. so really it was me
> turning on HAVE_STAT64 (in our Android makefile) after applying this
> aarch64-only fix that broke x86_64. strictly speaking, this was the
> change that broke the build:
> https://android-review.googlesource.com/#/c/83896/

Could you then update the wording of your commit message, please?

> >> The workaround needed to be applied to all LP64 architectures, not
> >> just aarch64. This patch fixes that and adds an explanatory comment.
> >>
> >> Change-Id: I73d495c7c52a72c5d34a803e106244e187c23e32
> >
> > What is Change-Id?
> it's an Android git/gerrit thing. i wanted to use "git format-patch"
> to send you the patch rather than just "git diff" which means i have
> to commit, and committing automatically assigns a Change-Id. since
> i'll just abandon my change and then cherrypick and submit whatever
> you submit upstream, this is meaningless. the cherrypick will get a
> new Change-Id.

In other words, it has no meaning in strace.git and I can safely drop it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20140313/9ae9716d/attachment.bin>

More information about the Strace-devel mailing list