improved SI_TIMER decoding

Mike Frysinger vapier at gentoo.org
Tue Mar 11 04:03:01 UTC 2014


On Tue 11 Mar 2014 05:50:04 Dmitry V. Levin wrote:
> On Mon, Mar 10, 2014 at 09:21:19PM -0400, Mike Frysinger wrote:
> > On Mon 10 Mar 2014 17:40:17 enh wrote:
> > > i think we might be talking at cross purposes. the pid/uid stuff that
> > > 
> > > isn't relevant for SI_TIMER isn't in sigval_t; it's in siginfo_t. i
> > > did factor out the sigval_t stuff.
> > 
> > yes, you factored out sigval_t, but you also copied & pasted the pid/uid
> > decoding in three places (SI_USER/SI_TKILL/default) where it only existed
> > in one place before.
> 
> Actually, there were two such places, raised to five after my change,
> so I've factored it out.

LGTM, thanks !
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20140311/ba0cc6b9/attachment.bin>


More information about the Strace-devel mailing list