[GSOC 2014] Multiarch support
Dmitry V. Levin
ldv at altlinux.org
Fri Jun 27 01:05:36 UTC 2014
On Thu, Jun 26, 2014 at 01:27:24PM -0500, Edson Ticona wrote:
> I am refactoring in such a way that functions relaying on specific
> personalities are isolated on its own file. The patch has the concrete
> case of printllval function which relies on different architectures
> types; I removed it from util.c and inserted the adequate version on
> The Makefile.am has to be updated so that this works.
> Furthermore, many definitions in the defs.h have to be moved in a similar way.
Sorry, but your patch looks completely pointless.
I don't see what it has to do with multiarch support.
For example, x86_64 supports 3 personalities (x86_64, i386 and x32),
so it may require 3 different implementations, but your scheme does not
allow 3 different implementations to be linked into a single executable.
Are you going to make 25 clones of every personality-specific function?
I suppose there are hundreds of them.
I agree all personality specific code needs to be isolated, but it
certainly shouldn't be cloned for each architecture.
First of all, please have a look at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: not available
More information about the Strace-devel