[PATCH v2] Print absolute paths in printpathn when -yy is used
zubin.mithra at gmail.com
Fri Jun 13 07:52:30 UTC 2014
Thank you for your response. Ill fix the issues and send a fix over asap.
> > + ssize_t n;I suppose incremented "n" would make the code a bit
> simpler, e.g.
> cwd[n++] = '/';
> cwd[n++] = '\0';
> outstr = alloca(4 * n); /* 4*(n-1) + 3 for quotes and NUL
> The first line would be cwd[n] and not n++ I believe. Im not sure a
simplification as shown above would be possible.
Now it doesn't compile for me:
> util.c: In function 'printpathn':
> util.c:595:4: error: implicit declaration of function 'print_tracee_cwd'
> Yes, I configure strace build using --enable-gcc-Werror, and I recommend
> everybody who is going to submit patches to do the same.
Will do. Should I be passing that as an argument to "bootstrap"?
> By the way, -yy is a user visible feature, so it needs to be documented.
Ill modify the strace.1 file accordingly.
-- Sent from an iPhone
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Strace-devel