[PATCH] net: add more sockopt options

Mike Frysinger vapier at gentoo.org
Mon Feb 17 08:18:44 UTC 2014


On Monday, February 17, 2014 02:51:17 Dmitry V. Levin wrote:
> On Sun, Feb 16, 2014 at 02:24:47AM -0500, Mike Frysinger wrote:
> > On Wednesday, February 05, 2014 06:40:05 Dmitry V. Levin wrote:
> [...]
> 
> > > I've automatically converted most of xlat structures to this XLAT form.
> > 
> > looks great.  the ifdef stuff still annoys me.  we can't really define
> > 
> > fallbacks to random values since any value is possible with these things.
> > what if we created like .xlat.in files ?  a script would take care of
> > generating the full contents.  see the crazy idea below.
> 
> Very nice!  What a pity not all constants are macros.
> 
> [...]
> 
> > +gen_header() {
> > +	local input="$1" output="$2" name="$3"
> > +	local line
> > +	echo "generating ${output}"
> > +	(
> > 
> > +	echo "/* Generated by $0 from $1; do not edit. */"
> > +	echo "const struct xlat ${name}[] = {"
> 
> static?

i started with that, but not all xlat's are static like addrfams :(.  but i 
didn't want to try extending the file format too much to support this as then 
we'd have this giant ad-hoc mess.  any suggestions on any semi-existing 
standards/structured file formats to use ?

how do you feel about using python in the build system ?  it wouldn't impact 
the released tarball, just maintainers.

> > +	while read line ; do
> > +		case ${line} in
> > +		"/"|"#"|"")
> 
> You mean
> 	/*|\#*|'')
> to forward preprocessor directives and comments?

true
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20140217/84663131/attachment.bin>


More information about the Strace-devel mailing list