[PATCHv4 2/2] tests: add a test for decoding the address of unix socket

Masatake YAMATO yamato at redhat.com
Mon Dec 29 09:30:05 UTC 2014


> On Mon, Dec 29, 2014 at 11:49:30AM +0900, Masatake YAMATO wrote:
>> > On Wed, Dec 24, 2014 at 08:59:32PM +0900, Masatake YAMATO wrote:
>> >> * tests/Makefile.am: Add unix-yy.test to TESTS.
>> >>   Add unix-yy-accept.awk and unix-yy-connect.awk to EXTRA_DIST.
>> >> * tests/unix-yy-accept.awk: New file.
>> >> * tests/unix-yy-connect.awk: New file.
>> >> * tests/unix-yy.test: New file.
>> > 
>> > Applied, thanks.
>> 
>> Thank you.
>>  
>> > BTW, I have a perfectly legitimate system where modules aren't loaded
>> > automatically and this test fails there when tcp_diag module is loaded but
>> > unix_diag module is not loaded.  I fixed this issue in a follow-up commit.
>> 
>> Do you mean loading unix_diag in setup stage of test, or just ignore the
>> result of test when unix_diag is not loaded? 
>> (or using something other technique)
> 
> I mean that the interface tested by netlink_inet_diag is not exactly the
> same interface that is needed for unix-yy.test, so I added
> netlink_unix_diag and changed unix-yy.test to use it instead of
> netlink_inet_diag.

I see. Thank you.

Masatake YAMATO
 
> 
> -- 
> ldv




More information about the Strace-devel mailing list