[PATCH 2/3] Support unix sockets in -yy option

[Dmitry V. Levin]

On Tue, Dec 09, 2014 at 12:33:23PM +0900, Masatake YAMATO wrote:
> BTW,
> 
> > * linux/unix_diag.h: New file.
> > * linux/rtnetlink.h: New file.
> 
> Should I bundle linux/unix_diag.h and linux/rtnetlink.h in
> my changes? (I included the shrunk version of them in my changes.)
> 
> I'm not sure the criteria which .h files are included in strace
> or not.

The tradition to bundle stripped-down editions of linux/ .h files is
quite recent, the idea behind it was to reduce the number of autoconf
tests and ifdefs in the code.  I'm not sure this was well thought out,
though, because we've got several GPLv2-only header files in the project
which is distributed under the BSD-style 3-clause license, which is not
compatible with GPL because of that advertising clause.

That is, do not bundle drop-in replacements of linux/ .h files if you
can avoid it.  What you need from <linux/rtnetlink.h> is essentially
unchanged for more than 10 years, so you can safely include it.
The constants you use from <linux/unix_diag.h> were not all available
before v3.3, so more care should be taken.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20141209/8a5988cb/attachment.bin>