x32 regressions

[Mike Frysinger]

On Wednesday 01 May 2013 18:49:02 Dmitry V. Levin wrote:
> @@ -230,6 +253,12 @@ printflock(struct tcb *tcp, long addr, int getlk)
>  	struct flock fl;
> 
>  #if SUPPORTED_PERSONALITIES > 1
> +# ifdef X32
> +	if (current_personality == 0) {
> +		printflock64(tcp, addr, getlk);
> +		return;
> +	}
> +# endif

hmm, to review the actual patch now, shouldn't we start a new symbol rather 
than using X32 ?  i'm pretty sure all these issues X32 is running into also 
affects MIPS's n32 ABI as they're largely the same concept -- native 64bit CPU 
where the ABI uses 32bit longs/pointers but the syscall API is 64bit.

granted, it's not a regression, but maybe now would be a good time to start 
thinking about this ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20130501/0a45b93a/attachment.bin>