x32 regressions

[Dmitry V. Levin]

On Wed, May 01, 2013 at 01:31:50PM -0400, Mike Frysinger wrote:
> On Wednesday 01 May 2013 13:01:41 Dmitry V. Levin wrote:
> > On Wed, May 01, 2013 at 12:34:27PM -0400, Mike Frysinger wrote:
> > > > 	x86_64 (x32) (linux-3.8.3 glibc-2.16 gcc-4.7.1) also fails:
> > Looks like x32 was broken by commit v4.7-96-g8435d67.
> > 
> > > looks like you're already working on this.  the latest git rev now looks
> > > like: file.c:2787:1: error: redefinition of ‘sys_fstat64’
> > > file.c:1334:1: note: previous definition of ‘sys_fstat64’ was here
> > > file.c:2799:1: error: redefinition of ‘sys_stat64’
> > > file.c:1243:1: note: previous definition of ‘sys_stat64’ was here
> > > make[2]: *** [file.o] Error 1
> > 
> > Please try this fix (I have no x32 nearby to check):
> 
> that gets me:
> file.c: In function ‘printstat64’:
> file.c:1068:2: error: size of unnamed array is negative

Well, it probably also needs this:

diff --git a/file.c b/file.c
index b6133db..adf3356 100644
--- a/file.c
+++ b/file.c
@@ -117,7 +117,7 @@ struct stat64 {
 	unsigned long		st_ctime;
 	unsigned long		st_ctime_nsec;
 	unsigned long long	st_ino;
-};
+} __attribute__((packed));
 # define HAVE_STAT64	1
 # define STAT64_SIZE	96
 

-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20130501/358a44fc/attachment.bin>