[PATCH] Print io_submit() offsets in decimal

Dmitry V. Levin ldv at altlinux.org
Sun Mar 31 01:38:31 UTC 2013

On Sat, Mar 30, 2013 at 07:19:50PM -0500, Zev Weiss wrote:
> On Mar 30, 2013, at 6:17 PM, Dmitry V. Levin wrote:
> > On Fri, Mar 29, 2013 at 03:37:00PM -0500, Zev Weiss wrote:
> >> Hello,
> >> 
> >> Current strace prints the offset members of iocb structs passed to io_submit() in hex, which I can't see any particular reason for (it mismatches the normal pread/pwrite format, for one thing), and the additional lack of a leading "0x" prefix makes it unnecessarily difficult to parse.  Could the below patch be applied to instead print them in decimal?
> > 
> > Yes, let's change it to match the pread/pwrite output format.
> > Would you like to write a commit message?
> > 
> Sure, hopefully the version below is formatted appropriately...
> Also, I noticed that the rest of the strace codebase uses %d for decimal integers, so I changed the patch to match (I had initially used %i).

Applied, thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20130331/a306c374/attachment.bin>

More information about the Strace-devel mailing list