[PATCH v2] USE_SEIZE: fix detaching from stopped processes

Denys Vlasenko dvlasenk at redhat.com
Wed Jun 19 12:27:30 UTC 2013

On 06/19/2013 01:24 PM, Dmitry V. Levin wrote:
> On Wed, Jun 19, 2013 at 12:58:13PM +0200, Denys Vlasenko wrote:
>> V2: check WSTOPSIG(status) == syscall_trap_sig, not SIGTRAP.
>> Add comments explaining what we think about the process status
>> in detach() at various steps. Simplify PTRACE_CONT
>> in wait loop since now syscall_trap_sig can't be seen there.
>> Verified that tests/detach works.
> With this patch,
> tests/detach-running fails (detach hangs) in use_seize case,
> tests/detach-sleeping fails (detach hangs) in !use_seize case.

First - _excellent_ tests! We missed them a lot!

Looking at it. It is more complicated than it looks :/
Expect a patch later today.

More information about the Strace-devel mailing list