[PATCH] Improve perf_event_open argument decoding

Dmitry V. Levin ldv at altlinux.org
Wed Feb 6 01:30:10 UTC 2013


On Wed, Feb 06, 2013 at 12:57:34AM +0100, Ben Noordhuis wrote:
> On Wed, Feb 6, 2013 at 12:31 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > On Mon, Feb 04, 2013 at 12:04:57AM +0100, Ben Noordhuis wrote:
> >> * configure.ac: Add <linux/perf_event.h> check.
> >> * desc.c: Add sys_perf_event_open
> >
> > I've added missing bits to the changelog entry, fixed a typo and
> > applied this.  Thanks,
> 
> Are you open to a patch that decodes the perf_event_attr struct?
> 
> I didn't do it in this patch because the struct is pretty big,
> something like twenty fields and growing.  I'm not sure how to best
> present that in the output.

Most of big structs are abbreviated by default, it might be reasonable to
follow this convention and abbreviate perf_event_attr by default, too.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20130206/bf5fe049/attachment.bin>


More information about the Strace-devel mailing list