[SCM] strace branch, master, updated. v4.6-333-g31972d5

[Denys Vlasenko]

On 03/17/2012 01:49 PM, Dmitry V. Levin wrote:
> On Sat, Mar 17, 2012 at 12:28:50PM +0000, Denys Vlasenko wrote:
>> commit 31972d52b1059d8faca1c5f417c2db1a90b868ae
>> Author: Denys Vlasenko<vda.linux at googlemail.com>
>> Date:   Sat Mar 17 13:23:00 2012 +0100
>>
>>      Remove underscores from a few syscall names which have them
>
> I think this change is wrong.
>
>>      Affected names are "_newselect", "_llseek", "_sysctl".
>>      I see no apparent reason why they have leading underscores.
>>      Moreover, some arches have underscored names and some have
>>      non-underscored ones. This is not consistent.
>
> The naming consistency does not matter here.  It is not our business to
> give syscalls consistent names.  All we have to do about syscall names is
> just to follow the kernel.  And the kernel still exports some names with
> leading underscores, e.g.
> $ git grep '[[:space:]]_' arch/x86/syscalls/syscall_32.tbl
> arch/x86/syscalls/syscall_32.tbl:140	i386	_llseek			sys_llseek
> arch/x86/syscalls/syscall_32.tbl:142	i386	_newselect		sys_select			compat_sys_select
> arch/x86/syscalls/syscall_32.tbl:149	i386	_sysctl			sys_sysctl			compat_sys_sysctl

I reverted this change. Sorry.

-- 
vda