[PATCH] Decode /dev/loop ioctls

Mike Frysinger vapier at gentoo.org
Wed Apr 18 02:07:18 UTC 2012


On Tuesday 17 April 2012 20:23:49 Dmitry V. Levin wrote:
> On Tue, Apr 17, 2012 at 04:36:12PM -0400, Mike Frysinger wrote:
> > +		if (!abbrev(tcp)) {
> > +			tprintf("device=%" PRIi64 ", inode=%" PRIi64 ", "
> > +				"rdevice=%" PRIi64 ", offset=%#" PRIx64 ", "
> > +				"sizelimit=%" PRIi64 ", number=%" PRIi32,
> > +				(uint64_t) info64.lo_device,
> > +				(uint64_t) info64.lo_inode,
> > +				(uint64_t) info64.lo_rdevice,
> > +				(uint64_t) info64.lo_offset,
> > +				(uint64_t) info64.lo_sizelimit,
> > +				(uint32_t) info64.lo_number);
> > +		} else {
> 
> We can have more consistency here, e.g. natural printing format specifiers
> for uint64_t are PRIu64 and PRIx64, while PRIi64 is more appropriate for
> the signed type.

sure ... was just an oversight
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20120417/649b4091/attachment.bin>


More information about the Strace-devel mailing list