[SCM] strace branch, master, updated. v4.6-115-g102ec49

Denys Vlasenko dvlasenk at redhat.com
Thu Sep 1 09:14:34 UTC 2011


On Wed, 2011-08-31 at 20:56 +0400, Dmitry V. Levin wrote:
> On Wed, Aug 31, 2011 at 03:19:16PM +0200, Denys Vlasenko wrote:
> > On Wed, 2011-08-31 at 16:25 +0400, Dmitry V. Levin wrote:
> > > On Wed, Aug 31, 2011 at 02:04:52PM +0200, Denys Vlasenko wrote:
> > > > On Tue, 2011-08-30 at 20:20 +0400, Dmitry V. Levin wrote:
> [...]
> > > > > Maybe we could use
> > > > > 		tprintf("%s", acolumn_spaces + curcol);
> > > > > instead without performance degradation?
> > > > 
> > > > There will be some performance degradation.
> > > > Is there a way to suppress this warning on a case-by-case basis?
> > > 
> > > I'm not aware of such a way.  If the performance degradation is
> > > noticeable, a straightforward function tprint_str(const char *str) could
> > > be added to do exactly that.  The implementation could use fputs() instead
> > > of vfprintf(), and that would speedup things even more than now. ;)
> > 
> > Something like this?
> [...]
> > --- strace.4/defs.h	2011-08-31 13:53:17.000000000 +0200
> > +++ strace.5/defs.h	2011-08-31 15:04:13.625365787 +0200
> > @@ -708,6 +708,7 @@ extern int proc_open(struct tcb *tcp, in
> >  	printtv_bitness((tcp), (addr), BITNESS_CURRENT, 1)
> >  
> >  extern void tprintf(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
> > +extern void tprints(const char *str);
> >  
> >  #ifndef HAVE_STRERROR
> >  const char *strerror(int);
> 
> Yes.

Committed, thanks!
-- 
vda






More information about the Strace-devel mailing list