[PATCH] "modernize" all old-style function parameter declarations

Dmitry V. Levin ldv at altlinux.org
Sat May 28 20:45:25 UTC 2011


On Fri, May 27, 2011 at 03:00:59PM +0200, Denys Vlasenko wrote:
> diff -p option prints "what function we are in" header
> before each hunk. Example:
> 
>     @@ -440,19 +440,18 @@ static void parse_config_file(void)
> 
> strace source, however, upsets working of this option because
> we have (very-)old-style C function definitions in some places.
> Even though they are gradually replaced, I still often
> have broken "diff -p" output which shows last parameter
> declaration instead of function name.
> 
> This patch converts all remaining old-style C function definitions
> to a "modern" form. This does not change any actual code.

The change is definitely OK if it really doesn't change any actual code.
If you are sure there is no accidental mistake, please commit.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110529/0e9c9251/attachment.bin>


More information about the Strace-devel mailing list