[PATCH] Add support for ARC architecture (Synopsys)

[Mike Frysinger]

On Tuesday, March 15, 2011 08:28:40 Vineet Gupta wrote:
> +	}
> +	else {

there's a few of these in this patch.  i think they need to all be:
	} else {

> +		memcpy(&sigm, tcp->u_arg + 1, sizeof (sigm));

no space before that open paren

> +# elif defined(ARC)
> +		int r0;
> +		/* get the sya-call return value */
> +		if (upeek(tcp, PT_r0, &r0) < 0)
> +			return -1;
> +
> +				/* A signed -ve value doesn't rightaway mean error.
> +				 * some calls such as mmap can return high values which if 
treated
> +				 * as signed would look like errno. Make sure thats's not 
the case
> +				 */

indentation on that comment block looks like it's too far

> +	/* Needed by strace -i to print the PC of syscall trap insn
> +	*/

should be all on one line
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110315/22e0449e/attachment.bin>